From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751195AbbLNFCZ (ORCPT ); Mon, 14 Dec 2015 00:02:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:44142 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbbLNFCY (ORCPT ); Mon, 14 Dec 2015 00:02:24 -0500 Date: Mon, 14 Dec 2015 00:02:22 -0500 (EST) Message-Id: <20151214.000222.959007472004329129.davem@davemloft.net> To: haiyangz@microsoft.com Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field From: David Miller In-Reply-To: <1449778775-14404-1-git-send-email-haiyangz@microsoft.com> References: <1449778775-14404-1-git-send-email-haiyangz@microsoft.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 13 Dec 2015 21:02:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Thu, 10 Dec 2015 12:19:35 -0800 > In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the > locking for MSD (Multi-Send Data) field was removed. This could cause a > race condition between RNDIS control messages and data packets processing, > because these two types of traffic are not synchronized. > This patch fixes this issue by sending control messages out directly > without reading MSD field. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied.