From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932203AbbLNKZz (ORCPT ); Mon, 14 Dec 2015 05:25:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbbLNKZy (ORCPT ); Mon, 14 Dec 2015 05:25:54 -0500 Date: Mon, 14 Dec 2015 11:25:51 +0100 From: Jiri Olsa To: Josh Poimboeuf Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v3 14/17] perf: Remove subcmd dependencies on strbuf Message-ID: <20151214102551.GA9449@krava.brq.redhat.com> References: <3454b82dcc683d8ae581ca123de47578ee5a5e3c.1449965119.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3454b82dcc683d8ae581ca123de47578ee5a5e3c.1449965119.git.jpoimboe@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 13, 2015 at 10:18:14PM -0600, Josh Poimboeuf wrote: > Introduce and use new astrcat() and astrcatf() functions which replace > the strbuf functionality for subcmd. hum, would it be better then to put strbuf into lib as well? jirka