From: Matt Fleming <matt@codeblueprint.co.uk>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Fix misleading indentation issues in perf
Date: Mon, 14 Dec 2015 10:46:07 +0000 [thread overview]
Message-ID: <20151214104607.GA2571@codeblueprint.co.uk> (raw)
In-Reply-To: <20151212180702.GA753@x4>
On Sat, 12 Dec, at 07:07:02PM, Markus Trippelsdorf wrote:
> perf doesn't build with gcc-6 because of several misleading-indentation
> warnings, e.g.:
>
> arch/x86/tests/intel-cqm.c: In function ‘spawn’:
> arch/x86/tests/intel-cqm.c:21:3: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
> sleep(5);
> ^~~~~
>
> arch/x86/tests/intel-cqm.c:20:2: note: ...this ‘while’ clause, but it is not
> while(1);
> ^~~~~
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
>
> diff --git a/tools/perf/arch/x86/tests/intel-cqm.c b/tools/perf/arch/x86/tests/intel-cqm.c
> index d28c1b6a3b54..fa5d17af88b7 100644
> --- a/tools/perf/arch/x86/tests/intel-cqm.c
> +++ b/tools/perf/arch/x86/tests/intel-cqm.c
> @@ -17,7 +17,7 @@ static pid_t spawn(void)
> if (pid)
> return pid;
>
> - while(1);
> + while(1)
> sleep(5);
> return 0;
> }
Whoops. Good catch.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
next prev parent reply other threads:[~2015-12-14 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 18:07 Markus Trippelsdorf
2015-12-14 8:19 ` Ingo Molnar
2015-12-14 10:46 ` Matt Fleming [this message]
2015-12-14 15:14 ` Arnaldo Carvalho de Melo
2015-12-14 15:43 ` [PATCH 1/3] Remove wrong semicolon in while loop Markus Trippelsdorf
2015-12-14 17:55 ` Arnaldo Carvalho de Melo
2016-01-30 8:24 ` [tip:perf/urgent] perf tests: Remove wrong semicolon in while loop in CQM test tip-bot for Markus Trippelsdorf
2015-12-14 15:44 ` [PATCH 2/3] Add missing braces to if statement Markus Trippelsdorf
2016-01-30 8:24 ` [tip:perf/urgent] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed tip-bot for Markus Trippelsdorf
2015-12-14 15:44 ` [PATCH 3/3] Fix misleadingly indented assignment (whitespace) Markus Trippelsdorf
2016-02-03 10:06 ` [tip:perf/core] perf pmu: Fix misleadingly indented assignment ( whitespace) tip-bot for Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214104607.GA2571@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome