From: Thierry Reding <thierry.reding@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
"Terje Bergström" <tbergstrom@nvidia.com>,
"David Airlie" <airlied@linux.ie>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jason Cooper" <jason@lakedaemon.net>
Subject: Re: [PATCH 5/9] drm/tegra: dc: add missing of_node_put
Date: Mon, 14 Dec 2015 14:35:39 +0100 [thread overview]
Message-ID: <20151214133539.GA986@ulmo.nvidia.com> (raw)
In-Reply-To: <1445697755-26341-6-git-send-email-Julia.Lawall@lip6.fr>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Sat, Oct 24, 2015 at 04:42:31PM +0200, Julia Lawall wrote:
> for_each_matching_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> local idexpression n;
> expression e;
> @@
>
> for_each_matching_node(n,...) {
> ...
> (
> of_node_put(n);
> |
> e = n
> |
> + of_node_put(n);
> ? break;
> )
> ...
> }
> ... when != n
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/gpu/drm/tegra/dc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-14 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 14:42 [PATCH 0/9] " Julia Lawall
2015-10-24 14:42 ` [PATCH 1/9] powerpc/powernv: " Julia Lawall
2015-10-24 14:42 ` [PATCH 2/9] leds: bcm6358: " Julia Lawall
2015-10-24 14:42 ` [PATCH 3/9] leds: bcm6328: " Julia Lawall
2015-10-24 14:42 ` [PATCH 4/9] leds: 88pm860x: " Julia Lawall
2015-10-24 14:42 ` [PATCH 5/9] drm/tegra: dc: " Julia Lawall
2015-12-14 13:35 ` Thierry Reding [this message]
2015-10-24 14:42 ` [PATCH 6/9] Bluetooth: btmrvl: " Julia Lawall
2015-10-25 19:54 ` Marcel Holtmann
2015-10-24 14:42 ` [PATCH 7/9] gpu: host1x: " Julia Lawall
2015-10-24 14:42 ` [PATCH 8/9] soc: ti: knav_qmss_queue: " Julia Lawall
2015-10-24 14:42 ` [PATCH 9/9] pinctrl: at91: " Julia Lawall
2015-10-26 9:52 ` Ludovic Desroches
2015-10-27 16:18 ` Linus Walleij
2015-10-26 8:48 ` [PATCH 0/9] " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214133539.GA986@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@wwwdotorg.org \
--cc=tbergstrom@nvidia.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome