From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbbLNQWr (ORCPT ); Mon, 14 Dec 2015 11:22:47 -0500 Received: from foss.arm.com ([217.140.101.70]:43968 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbLNQWq (ORCPT ); Mon, 14 Dec 2015 11:22:46 -0500 Date: Mon, 14 Dec 2015 16:22:42 +0000 From: Catalin Marinas To: Julien Grall Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, stefano.stabellini@eu.citrix.com Subject: Re: [PATCH] arm64: Add missing linux/bug.h include in asm/pgtable.h Message-ID: <20151214162242.GA27918@e104818-lin.cambridge.arm.com> References: <1450109244-20122-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450109244-20122-1-git-send-email-julien.grall@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 04:07:24PM +0000, Julien Grall wrote: > Linux 4.4-rc5 doesn't build for arm64 with CONFIG_XEN=y enabled: > > In file included from linux/arch/arm64/include/asm/pgtable.h:60:0, > from linux/arch/arm64/include/../../arm/include/asm/xen/page.h:5, > from linux/arch/arm64/include/asm/xen/page.h:1, > from linux/include/xen/page.h:28, > from linux/arch/arm64/xen/../../arm/xen/grant-table.c:33: > linux/arch/arm64/include/asm/pgtable.h: In function 'set_pte_at': > linux/include/linux/mmdebug.h:49:39: error: implicit declaration of function 'BUILD_BUG_ON_INVALID' [-Werror=implicit-function-declaration] > #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) > ^ > linux/arch/arm64/include/asm/pgtable.h:281:3: note: in expansion of macro 'VM_WARN_ONCE' > VM_WARN_ONCE(!pte_young(pte), > ^ > > This has been introduced by commit 82d340081b6f71237373d1452e3573a5a122794c > "arm64: Improve error reporting on set_pte_at() checks". This is because > mmdebug.h relies on the includer to properly include the dependencies. > > Signed-off-by: Julien Grall > > --- > Cc: Stefano Stabellini > Cc: Catalin Marinas > Cc: Will Deacon > > I was tempted to add the missing include in linux/mmdebug.h but I'm > not sure about the policy for headers inclusion in Linux. Normally, I would say that mmdebug.h should include whichever headers it needs but for a quicker fix, I'm fine with including linux/bug.h (and probably removing the asm/bug.h include in asm/pgtable.h). -- Catalin