From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753773AbbLODLM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 22:11:12 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:55182 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752095AbbLODLK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 22:11:10 -0500
Date: Mon, 14 Dec 2015 19:11:09 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de,
        apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com,
        Kamal Mostafa <kamal@canonical.com>
Subject: Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with
 __EXPORTED_HEADERS__
Message-ID: <20151215031109.GB4040@kroah.com>
References: <1450137698-26327-1-git-send-email-kys@microsoft.com>
 <1450137718-26366-1-git-send-email-kys@microsoft.com>
 <1450137718-26366-22-git-send-email-kys@microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450137718-26366-22-git-send-email-kys@microsoft.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
> From: Kamal Mostafa <kamal@canonical.com>
> 
> Use the local uapi headers to keep in sync with "recently" added #define's
> (e.g. VSS_OP_REGISTER1).
> 
> Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb

Please use the "correct" way of listing this:
	3eb2094c59e8 ("Adding makefile for tools/hv")

And as this is an old kernel, shouldn't it go into stable releases?  Or
does that mean that no one really ever runs into this issue?

> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  tools/hv/Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> index a8ab795..a8c4644 100644
> --- a/tools/hv/Makefile
> +++ b/tools/hv/Makefile
> @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
>  WARNINGS = -Wall -Wextra
>  CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
>  
> +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include

Why do you need ../../include also?

thanks,

greg k-h