From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964782AbbLOJDm (ORCPT ); Tue, 15 Dec 2015 04:03:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42403 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078AbbLOJDe (ORCPT ); Tue, 15 Dec 2015 04:03:34 -0500 Date: Tue, 15 Dec 2015 10:03:29 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCH 6/6] perf tools: Try to show pretty printed output for dynamic sort keys Message-ID: <20151215090329.GE16565@krava.brq.redhat.com> References: <1450107973-2447-1-git-send-email-namhyung@kernel.org> <1450107973-2447-7-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450107973-2447-7-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2015 at 12:46:13AM +0900, Namhyung Kim wrote: > Each tracepoint event has format string for print to improve > readability. Try to parse the output and match the field name. If it > finds one, use that for the result. If not, fallbacks to the original > output. > > For example, sort on kmem:kmalloc.gfp_flags looks like below: > (Note: libtraceevent plugins are not installed on my system. They might > affect the output below) > > Before: > # Overhead Command gfp_flags > # ........ ....... .......... > # > 99.89% perf 32848 > 0.06% sleep 208 > 0.03% perf 32976 > 0.01% perf 208 > > After: > # Overhead Command gfp_flags > # ........ ....... ................... > # > 99.89% perf GFP_NOFS|GFP_ZERO > 0.06% sleep GFP_KERNEL > 0.03% perf GFP_KERNEL|GFP_ZERO > 0.01% perf GFP_KERNEL hum, maybe we want some way to switch back to numbers? jirka