From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933604AbbLOOw7 (ORCPT ); Tue, 15 Dec 2015 09:52:59 -0500 Received: from foss.arm.com ([217.140.101.70]:49423 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbbLOOw6 (ORCPT ); Tue, 15 Dec 2015 09:52:58 -0500 Date: Tue, 15 Dec 2015 14:52:43 +0000 From: Mark Rutland To: Jisheng Zhang Cc: Arnd Bergmann , sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes Message-ID: <20151215145243.GB7041@leverpostej> References: <1450190172-1161-1-git-send-email-jszhang@marvell.com> <8261316.NuheDtlQ6N@wuerfel> <20151215224709.2d71d2ba@xhacker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151215224709.2d71d2ba@xhacker> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote: > Dear Arnd, > > On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote: > > > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote: > > > - compatible = "arm,armv8-pmuv3"; > > > + compatible = "arm,cortex-a53-pmu"; > > > > > > > Should this list both? > > IMHO, we don't need to list both. The pmu binding document also says: > "compatible : should be one of ...." > > Dear Mark, > > Could you please give suggestions? That should probably reads as "should contain at least one of". It's probably best to keep "arm,armv8-pmuv3" as a fallback in the compatible list. Thanks, Mark.