From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597AbbLPXXP (ORCPT ); Wed, 16 Dec 2015 18:23:15 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41385 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753209AbbLPXXN (ORCPT ); Wed, 16 Dec 2015 18:23:13 -0500 Date: Wed, 16 Dec 2015 18:23:10 -0500 (EST) Message-Id: <20151216.182310.1967561459941374668.davem@davemloft.net> To: haiyangz@microsoft.com Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers From: David Miller In-Reply-To: References: <1450289022-9958-1-git-send-email-haiyangz@microsoft.com> <1450285688.8474.86.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 16 Dec 2015 15:23:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Wed, 16 Dec 2015 19:20:44 +0000 > In our test, we have bisected and found the following patch introduced big > overhead into skb_flow_dissect_flow_keys(), and caused performance > regression: > commit: d34af823 > net: Add VLAN ID to flow_keys NEVER _EVER_ work around this kind of problem by bypassing the code in question in your driver. ALWAYS work to fix the actual problem.