From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933048AbbLPNYH (ORCPT ); Wed, 16 Dec 2015 08:24:07 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36573 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbbLPNYF (ORCPT ); Wed, 16 Dec 2015 08:24:05 -0500 Date: Wed, 16 Dec 2015 13:23:57 +0000 From: Mark Brown To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Message-ID: <20151216132357.GK5727@sirena.org.uk> References: <1450040037-28334-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kdFpxm//39tBKx/r" Content-Disposition: inline In-Reply-To: <1450040037-28334-1-git-send-email-paul.gortmaker@windriver.com> X-Cookie: revolutionary, adj.: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: Add builtin_spi_driver() to avoid registration boilerplate X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kdFpxm//39tBKx/r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 13, 2015 at 03:53:57PM -0500, Paul Gortmaker wrote: > Here we use that support and extend it to SPI driver registration, so where > a driver is clearly non-modular and builtin-only, we can register it in a > similar fashion. Existing code that is clearly non-modular can be updated > with the simple mapping of > module_spi_driver(...) ---> builtin_spi_driver(...) > We've essentially cloned the former to make the latter, and taken out the > remove/module_exit parts since those never get used in a non-modular build > of the code. Why would it be sensible to have a SPI driver that can't be built as a module? --kdFpxm//39tBKx/r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWcWXsAAoJECTWi3JdVIfQRdcH/j2mVFu/Cl2chuIB3wP/QfA9 yauV/HzfB86C3lAG3U/PBfMKw+9JtfoC+sC7FtvJtmAp9LKssyGYl2ufd2OdSDyn 08FOvsQjeSnr1lLFpyyCQ8ESCgheW2BYF36WzfcVugbF8kvP1Dkh0tEPPQ+EOyJ3 OZh/9jDqQiB2l8iAcz9bq0o+ViqMr5VB/EQoJ/qWIZ9SUKOIFi+i/H7V2rGhRS+e DZaWx91SpExkIuyEM2bCL1hGRp70UQYbvUASprCqmOS4Gfl9u+GjoEn6FfY2/P8h gTZDCLgbmDcMDpb8rB3IPhN/FNbzxnsBq/vQjpMVDXkkQdZjV91EaOcR90ULCyM= =JE3S -----END PGP SIGNATURE----- --kdFpxm//39tBKx/r--