From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965887AbbLPPoH (ORCPT ); Wed, 16 Dec 2015 10:44:07 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:45396 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965528AbbLPPoD convert rfc822-to-8bit (ORCPT ); Wed, 16 Dec 2015 10:44:03 -0500 Date: Wed, 16 Dec 2015 15:43:42 +0000 From: One Thousand Gnomes To: Frederik =?UTF-8?B?VsO2bGtlbA==?= Cc: gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, lukas.braun@fau.de, linux-kernel@i4.cs.fau.de Subject: Re: [PATCH v2 1/4] drivers: tty: 68328serial.c: Use tabs for indentation Message-ID: <20151216154342.15fb7230@lxorguk.ukuu.org.uk> In-Reply-To: <1450279021-17154-2-git-send-email-frederik.voelkel@fau.de> References: <1449830170-15096-1-git-send-email-frederik.voelkel@fau.de> <1450279021-17154-1-git-send-email-frederik.voelkel@fau.de> <1450279021-17154-2-git-send-email-frederik.voelkel@fau.de> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Dec 2015 16:16:58 +0100 Frederik Völkel wrote: > The patch replaces the spaces used for indentation at some points with > tabs. Are you actually still using this driver or just randomly cleaning stuff up. If the former is the case then there are some other fairly major things wrong with it, but otherwise I'd really suggest someone just deletes it instead. Alan