From: Dave Young <dyoung@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
Emmanuel Grumbach <egrumbach@gmail.com>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>
Subject: Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages
Date: Thu, 17 Dec 2015 11:16:52 +0800 [thread overview]
Message-ID: <20151217031652.GA3821@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <1449844729.2324.15.camel@sipsolutions.net>
Hi, Johannes
Sorry for late feedback, I was busying on other things.
On 12/11/15 at 03:38pm, Johannes Berg wrote:
> On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote:
> > cfg80211 module prints a lot of messages like below. Actually
> > printing once is acceptable but sometimes it will print again and
> > again, it looks very annoying. It is better to change these detail
> > messages to debugging only.
> >
>
> Despite the objections, I've applied this patch now.
>
Thanks a lot.
> I've made one change: keeping the alpha2 (e.g. "US") printed in some of
> the pr_err() cases in this file.
> I also got rid of CONFIG_CFG80211_REG_DEBUG in a separate patch.
>
> I somewhat agree with the objections, but if the kernel is with
> CONFIG_DYNAMIC_DEBUG then it's really simple to get the messages back
> by enabling them for this file.
>
> Where the messages were used as an indication of something having gone
> awry at a different level (e.g. mac80211 disconnect) I don't really
> quite agree - that then perhaps should have a more explicit (and less
> noisy) message.
>
> I also agree that the regulatory code is quite opaque, and the way it
> arrives at certain conclusions is not always obvious. These messages
> don't help all that much though since they don't contain the actual
> input to the decisions. I think for that, we'd be much better served
> with some kind of tracepoint or so that records all the information.
I think you guys are expert in this area, I will agree with all of
above. But I hope we can have some rate limited messages at least
especially for endless things.
Thanks
Dave
prev parent reply other threads:[~2015-12-17 3:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 7:31 Dave Young
2015-11-15 17:38 ` Joe Perches
2015-11-16 1:59 ` Dave Young
2015-11-16 10:38 ` Johannes Berg
2015-11-15 18:25 ` Stefan Lippers-Hollmann
2015-11-16 1:58 ` Dave Young
2015-11-20 11:55 ` Johannes Berg
2015-11-23 1:37 ` Dave Young
2015-12-11 14:26 ` Johannes Berg
2015-12-17 3:19 ` Dave Young
2015-12-17 7:58 ` Johannes Berg
2015-12-11 14:38 ` Johannes Berg
2015-12-17 3:16 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217031652.GA3821@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=davem@davemloft.net \
--cc=egrumbach@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®