From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967066AbbLQPHj (ORCPT ); Thu, 17 Dec 2015 10:07:39 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:50362 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965010AbbLQPHi (ORCPT ); Thu, 17 Dec 2015 10:07:38 -0500 Date: Thu, 17 Dec 2015 16:07:32 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, johannes@sipsolutions.net, Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers Message-ID: <20151217150732.GG6344@twins.programming.kicks-ass.net> References: <1449138762-15194-1-git-send-email-alexander.shishkin@linux.intel.com> <1449138762-15194-3-git-send-email-alexander.shishkin@linux.intel.com> <20151203173431.GC3816@twins.programming.kicks-ass.net> <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com> <20151208165700.GE6357@twins.programming.kicks-ass.net> <20151217134034.GM6373@twins.programming.kicks-ass.net> <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2015 at 04:25:14PM +0200, Alexander Shishkin wrote: > That aside, why I brought it up in the first place is because the two > functions are asymmetric: one is called with irqs disabled and the > other -- with ctx::lock held (and not because I'm into bikeshedding or > anything like that). Looking at the pair of them sets off my "that's not > right" trigger and sends me to the event_function_call() > implementation. So in that sense, prepending an extra underscore kind of > made sense. Maybe __perf_remove_from_context_{on,off}()? You are quite right, and I think I've found more problems because of this. Let me prod at this some more.