From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754296AbbLRQrJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Dec 2015 11:47:09 -0500
Received: from casper.infradead.org ([85.118.1.10]:39319 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751019AbbLRQrH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Dec 2015 11:47:07 -0500
Date: Fri, 18 Dec 2015 17:47:04 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        vince@deater.net, eranian@google.com, johannes@sipsolutions.net,
        Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 2/7] perf: Generalize task_function_call()ers
Message-ID: <20151218164704.GQ6344@twins.programming.kicks-ass.net>
References: <1449138762-15194-1-git-send-email-alexander.shishkin@linux.intel.com>
 <1449138762-15194-3-git-send-email-alexander.shishkin@linux.intel.com>
 <20151203173431.GC3816@twins.programming.kicks-ass.net>
 <87vb88yjs6.fsf@ashishki-desk.ger.corp.intel.com>
 <20151208165700.GE6357@twins.programming.kicks-ass.net>
 <20151217134034.GM6373@twins.programming.kicks-ass.net>
 <87k2odb19x.fsf@ashishki-desk.ger.corp.intel.com>
 <20151217150732.GG6344@twins.programming.kicks-ass.net>
 <20151218090129.GQ6373@twins.programming.kicks-ass.net>
 <87d1u3bxs9.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d1u3bxs9.fsf@ashishki-desk.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 18, 2015 at 05:07:34PM +0200, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> 
> > @@ -2774,9 +2696,6 @@ static void perf_event_context_sched_in(
> >  	 */
> >  	cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE);
> >  
> > -	if (ctx->nr_events)
> > -		cpuctx->task_ctx = ctx;
> > -
> >  	perf_event_sched_in(cpuctx, cpuctx->task_ctx, task);
> 
> This then should probably become
> 
>   	perf_event_sched_in(cpuctx, ctx, task);
> 
> otherwise task contexts just don't get scheduled any more.

Very good, thanks!

Running with that triggers another WARN, I'll have a look at that later
tonight.