From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wim Van Sebroeck <wim@iguana.be>,
Alexander Usyskin <alexander.usyskin@intel.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event
Date: Fri, 18 Dec 2015 18:14:12 +0000 [thread overview]
Message-ID: <20151218181412.49357bfe@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <56744757.2060101@roeck-us.net>
> > That breaks the existing behaviour of hot pluggable watchdog interfaces
> > and is different to just about any other device in the kernel. Today with
> > any desktop or server distribution you can already trivially arrange for
> > watchdog daemons to start at the point a watchdog is detected dynamically.
> >
>
> Ok, you have a point. Wonder if any distributions are doing that, though.
> Any idea ?
I don't know for any of the out of the box mainstream ones.
There is a second problem if you register the watchdog but don't actually
have it enabled. Consider the case where a user has the mei watchdog
disabled and a more advanced watchdog card plugged in - in that case the
naïvely implemented existing watchdog app may bind to the non-functional
watchdog, not the correct one.
Alan
next prev parent reply other threads:[~2015-12-18 18:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:49 [char-misc-next v2 0/7] mei: create proper iAMT watchdog driver Tomas Winkler
2015-12-17 14:49 ` [char-misc-next v2 1/7] mei: drop nfc leftovers from the mei driver Tomas Winkler
2015-12-17 14:49 ` [char-misc-next v2 2/7] mei: wd: drop the watchdog code from the core " Tomas Winkler
2015-12-17 14:49 ` [char-misc-next v2 3/7] watchdog: mei_wdt: implement MEI iAMT watchdog driver Tomas Winkler
2015-12-18 16:39 ` Guenter Roeck
2015-12-17 14:49 ` [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry Tomas Winkler
2015-12-18 16:43 ` Guenter Roeck
2015-12-20 9:44 ` Winkler, Tomas
2015-12-20 10:40 ` Guenter Roeck
2015-12-20 11:54 ` Winkler, Tomas
2015-12-17 14:49 ` [char-misc-next v2 5/7] mei: bus: whitelist the watchdog client Tomas Winkler
2015-12-17 14:49 ` [char-misc-next v2 6/7] watchdog: mei_wdt: register wd device only if required Tomas Winkler
2015-12-18 16:58 ` Guenter Roeck
2015-12-20 12:23 ` Winkler, Tomas
2015-12-20 18:16 ` Guenter Roeck
2015-12-17 14:49 ` [char-misc-next v2 7/7] watchdog: mei_wdt: re-register device on event Tomas Winkler
2015-12-18 17:05 ` Guenter Roeck
2015-12-18 17:19 ` One Thousand Gnomes
2015-12-18 17:50 ` Guenter Roeck
2015-12-18 18:14 ` One Thousand Gnomes [this message]
2015-12-20 12:53 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218181412.49357bfe@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alexander.usyskin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tomas.winkler@intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®