From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbbLSFLF (ORCPT ); Sat, 19 Dec 2015 00:11:05 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:54120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbLSFLC (ORCPT ); Sat, 19 Dec 2015 00:11:02 -0500 Date: Sat, 19 Dec 2015 00:10:58 -0500 (EST) Message-Id: <20151219.001058.862320196789855068.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, w-kwok2@ti.com, m-karicheri2@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] netcp: fix regression in receive processing From: David Miller In-Reply-To: <1651314.QiL8XMyoqS@wuerfel> References: <1651314.QiL8XMyoqS@wuerfel> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 18 Dec 2015 21:11:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Fri, 18 Dec 2015 15:18:08 +0100 > A cleanup patch I did was unfortunately wrong and introduced > multiple serious bugs in the netcp rx processing, as indicated > by these correct gcc warnings: > > drivers/net/ethernet/ti/netcp_core.c:776:14: warning: 'buf_ptr' may be used uninitialized in this function [-Wuninitialized] > drivers/net/ethernet/ti/netcp_core.c:687:14: warning: 'ptr' may be used uninitialized in this function [-Wuninitialized] > > I have checked the patch once more and found that a call to > get_pkt_info() accidentally got removed in netcp_free_rx_desc_chain, > and netcp_process_one_rx_packet no longer retrieved the correct > buffer length. This patch should fix all the known problems, > but I did not test on real hardware. > > Signed-off-by: Arnd Bergmann > Fixes: 899077791403 ("netcp: try to reduce type confusion in descriptors") Applied.