From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbbLSCdV (ORCPT ); Fri, 18 Dec 2015 21:33:21 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:56490 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523AbbLSCdU (ORCPT ); Fri, 18 Dec 2015 21:33:20 -0500 Date: Sat, 19 Dec 2015 10:33:08 +0800 From: Herbert Xu To: Tim Chen Cc: Russell King - ARM Linux , linux-kernel , "; linux-crypto" , "megha.dey" Subject: Re: ahash alg that does not implement import/export failed to register Message-ID: <20151219023308.GA27731@gondor.apana.org.au> References: <1450488694.30844.11.camel@schen9-desk2.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450488694.30844.11.camel@schen9-desk2.jf.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 18, 2015 at 05:31:34PM -0800, Tim Chen wrote: > Herbert, > > There are some ahash algorithms like x86's sha1-mb and > ghash that failed to register because of the newly added > check of non-zero statesize from commit 8996eafd. But > since there are algorithms that do not implement an import or > export, there is no state required for them. Wonder if the check > should be modified to something like: No import and export are required by algif_hash so they must be implemented. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt