From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753243AbbLSGjX (ORCPT <rfc822;w@1wt.eu>);
	Sat, 19 Dec 2015 01:39:23 -0500
Received: from mail-pf0-f175.google.com ([209.85.192.175]:34814 "EHLO
	mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752619AbbLSGjV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 19 Dec 2015 01:39:21 -0500
Date: Sat, 19 Dec 2015 12:09:14 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
        Grant Likely <grant.likely@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v4] of: fix declaration of of_io_request_and_map
Message-ID: <20151219063914.GB14071@sudip-pc>
References: <1449564475-10724-1-git-send-email-sudipm.mukherjee@gmail.com>
 <CAL_Jsq+f-LLfN4Q4bLFGhXj9KRb4aj7TRExuAUZbxrEtSbAW5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_Jsq+f-LLfN4Q4bLFGhXj9KRb4aj7TRExuAUZbxrEtSbAW5Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 17, 2015 at 11:55:28AM -0600, Rob Herring wrote:
> On Tue, Dec 8, 2015 at 2:47 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > We are having build failure with linux-next for sparc allmodconfig with
> > the error messages:
> >
> > drivers/built-in.o: In function `meson6_timer_init':
> > meson6_timer.c:(.init.text+0x5fe8): undefined reference to `of_io_request_and_map'
> > drivers/built-in.o: In function `mtk_timer_init':
> > mtk_timer.c:(.init.text+0x6af0): undefined reference to `of_io_request_and_map'
> > drivers/built-in.o: In function `asm9260_timer_init':
> > asm9260_timer.c:(.init.text+0x6c48): undefined reference to `of_io_request_and_map'
> >
> > CONFIG_OF is defined for sparc so it is expected that we have a
> > definition of of_io_request_and_map() but of/address.c is only compiled
> > if it is !SPARC. In other words, CONFIG_OF_ADDRESS is not defined for
> > sparc so we get the build failure.
> >
> > Fixes: e572f844ca66 ("clocksource/drivers/meson6: Add the COMPILE_TEST option")
> > Fixes: bec8c4617611 ("clocksource/drivers/mediatek: Add the COMPILE_TEST option")
> > Fixes: 4a373b45f94a ("clocksource/drivers/asm9260: Add the COMPILE_TEST option")
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> 
> Moved the include out of the ifdefs and applied, thanks.

Thanks, I was wondering if the include should be within the ifdefs or
outside. But since the original code had it inside ifdefs, i thought its
better to have it inside.

regards
sudip