From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbbLUPnA (ORCPT ); Mon, 21 Dec 2015 10:43:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbbLUPmg (ORCPT ); Mon, 21 Dec 2015 10:42:36 -0500 Date: Mon, 21 Dec 2015 16:42:32 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing Message-ID: <20151221154232.GA13912@krava.brq.redhat.com> References: <1450145059-22547-1-git-send-email-andi@firstfloor.org> <1450145059-22547-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450145059-22547-2-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 06:04:14PM -0800, Andi Kleen wrote: SNIP > - double avg, int cpu, enum aggr_mode aggr) > +void perf_stat__print_shadow_stats(struct perf_evsel *evsel, > + double avg, int cpu, > + struct perf_stat_output_ctx *out) > { > + void *ctxp = out->ctx; > + print_metric_t print_metric = out->print_metric; > double total, ratio = 0.0, total2; > int ctx = evsel_context(evsel); > > @@ -307,119 +302,145 @@ void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel, > total = avg_stats(&runtime_cycles_stats[ctx][cpu]); > if (total) { > ratio = avg / total; > - fprintf(out, " # %5.2f insns per cycle ", ratio); > + print_metric(ctxp, NULL, "%7.2f ", > + "insn per cycle", ratio); > } else { > - fprintf(out, " "); > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0); > } > total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]); > total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu])); > > + out->new_line(ctxp); > if (total && avg) { > ratio = total / avg; > - fprintf(out, "\n"); you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2 also please rebase to latest acme/perf/core FYI there's been some stat changes, but your branch cleanly rebased for me thanks, jirka