mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, peterz@infradead.org, jolsa@kernel.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org,
	eranian@google.com, namhyung@kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases
Date: Mon, 21 Dec 2015 17:16:04 +0100	[thread overview]
Message-ID: <20151221161604.GC21700@krava.brq.redhat.com> (raw)
In-Reply-To: <1450227266-2501-3-git-send-email-andi@firstfloor.org>

On Tue, Dec 15, 2015 at 04:54:18PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When an event alias is used that the kernel marked as .agg-per-core, force
> --per-core mode (and also require -a and forbid cgroups or per thread mode).
> This in term means, --topdown forces --per-core mode.
> 
> This is needed for TopDown in SMT mode, because it needs to measure
> all threads in a core together and merge the values to compute the correct
> percentages of how the pipeline is limited.
> 
> We do this if any alias is agg-per-core.
> 
> Add the code to parse the .agg-per-core attributes and propagate
> the information to the evsel. Then the main stat code does
> the necessary checks and forces per core mode.

please split it into 2 patches:
  - support .aggr-per-core alias parsing
  - force --per-core mode for .agg-per-core aliases

thanks,
jirka

  parent reply	other threads:[~2015-12-21 16:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  0:54 Add top down metrics to perf stat v2 Andi Kleen
2015-12-16  0:54 ` [PATCH 01/10] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen
2015-12-21 16:08   ` Jiri Olsa
2015-12-16  0:54 ` [PATCH 02/10] perf, tools, stat: Force --per-core mode for .agg-per-core aliases Andi Kleen
2015-12-16 14:16   ` Stephane Eranian
2015-12-21 16:14   ` Jiri Olsa
2015-12-21 16:16   ` Jiri Olsa [this message]
2015-12-16  0:54 ` [PATCH 03/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2015-12-16 14:22   ` Stephane Eranian
2015-12-16  0:54 ` [PATCH 04/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2015-12-16  0:54 ` [PATCH 05/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2015-12-16 14:32   ` Stephane Eranian
2015-12-16 21:21     ` Andi Kleen
2015-12-17  9:26       ` Stephane Eranian
2015-12-17 14:03         ` Andi Kleen
2015-12-16  0:54 ` [PATCH 06/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2015-12-16  0:54 ` [PATCH 07/10] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2015-12-16  0:54 ` [PATCH 08/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2015-12-16  8:53   ` Peter Zijlstra
2015-12-16 12:48   ` Stephane Eranian
2015-12-16 16:26     ` Andi Kleen
2015-12-16  0:54 ` [PATCH 09/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2015-12-16  0:54 ` [PATCH 10/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2015-12-17 10:27 ` Add top down metrics to perf stat v2 Stephane Eranian
2015-12-17 14:01   ` Andi Kleen
2015-12-17 23:31     ` Stephane Eranian
2015-12-18  1:55       ` Andi Kleen
2015-12-18  9:31         ` Stephane Eranian
2015-12-18 21:38           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221161604.GC21700@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®