From: Greg KH <gregkh@linuxfoundation.org>
To: Nizam Haider <nizamhaider786@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in>,
sudipm.mukherjee@gmail.com
Subject: Re: [PATCH v3 1/5] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay
Date: Mon, 21 Dec 2015 15:50:23 -0800 [thread overview]
Message-ID: <20151221235023.GA6591@kroah.com> (raw)
In-Reply-To: <1447512046-10412-1-git-send-email-nizamhaider786@gmail.com>
On Sat, Nov 14, 2015 at 08:10:42PM +0530, Nizam Haider wrote:
> Fix ceckpatch warning
spelling?
>
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 8106f52..cf5bfc7 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1335,7 +1335,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
> /* Check to see if the UART feels it completely flushed the FIFO. */
> tmp = readb(&ch->ch_neo_uart->isr_fcr);
> if (tmp & 4)
> - udelay(10);
> + usleep_range(10, 50);
Where did you get this range from? Did you make it up? Please don't.
greg k-h
prev parent reply other threads:[~2015-12-21 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 14:40 Nizam Haider
2015-11-14 14:40 ` [PATCH v3 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line Nizam Haider
2015-11-14 16:05 ` Andy Shevchenko
2015-11-14 14:40 ` [PATCH v3 3/5] Staging: dgnc: dgnc_neo.c: Spaces preferred around operators Nizam Haider
2015-11-14 14:40 ` [PATCH v3 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement Nizam Haider
2015-11-14 14:40 ` [PATCH v3 5/5] Staging: dgnc: dgnc_tty: Typo error dgnc_wmove comment Nizam Haider
2015-12-21 23:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221235023.GA6591@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nijamh@cdac.in \
--cc=nizamhaider786@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome