From: Andi Kleen <andi@firstfloor.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing
Date: Tue, 22 Dec 2015 02:16:30 +0100 [thread overview]
Message-ID: <20151222011630.GE15533@two.firstfloor.org> (raw)
In-Reply-To: <20151221154232.GA13912@krava.brq.redhat.com>
> > - fprintf(out, " ");
> > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0);
> > }
> > total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]);
> > total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu]));
> >
> > + out->new_line(ctxp);
> > if (total && avg) {
> > ratio = total / avg;
> > - fprintf(out, "\n");
>
> you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2
The new_line is always needed because stalled cycles is always printed.
The reason it is always printed is that metric-only needs to see all the
metrics for its column headers. That's why there are else cases
everywhere.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2015-12-22 1:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 2:04 perf, tools: Refactor and support interval and CSV metrics v7 Andi Kleen
2015-12-15 2:04 ` [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-12-21 15:42 ` Jiri Olsa
2015-12-22 1:16 ` Andi Kleen [this message]
2015-12-22 6:40 ` Jiri Olsa
2015-12-15 2:04 ` [PATCH 2/6] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-12-15 2:04 ` [PATCH 3/6] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-12-15 2:04 ` [PATCH 4/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-12-15 2:04 ` [PATCH 5/6] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-12-15 2:04 ` [PATCH 6/6] perf, tools, stat: Document CSV format in manpage Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222011630.GE15533@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome