From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbbLVGlJ (ORCPT ); Tue, 22 Dec 2015 01:41:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbbLVGkk (ORCPT ); Tue, 22 Dec 2015 01:40:40 -0500 Date: Tue, 22 Dec 2015 07:40:37 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing Message-ID: <20151222064037.GA13404@krava.brq.redhat.com> References: <1450145059-22547-1-git-send-email-andi@firstfloor.org> <1450145059-22547-2-git-send-email-andi@firstfloor.org> <20151221154232.GA13912@krava.brq.redhat.com> <20151222011630.GE15533@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151222011630.GE15533@two.firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2015 at 02:16:30AM +0100, Andi Kleen wrote: > > > - fprintf(out, " "); > > > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0); > > > } > > > total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]); > > > total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu])); > > > > > > + out->new_line(ctxp); > > > if (total && avg) { > > > ratio = total / avg; > > > - fprintf(out, "\n"); > > > > you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2 > > The new_line is always needed because stalled cycles is always printed. > > The reason it is always printed is that metric-only needs to see all the > metrics for its column headers. That's why there are else cases > everywhere. please notice extra line below - between instructions and cycles lines [jolsa@krava perf]$ ./perf stat -e instructions,cycles kill kill: not enough arguments Performance counter stats for 'kill': 769,784 instructions # 0.78 insn per cycle 990,795 cycles jirka