mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Noam Camus <noamc@ezchip.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
	vgupta@synopsys.com, Alexey.Brodkin@synopsys.com,
	jslaby@suse.com, peter@hurleysoftware.com
Subject: Re: [PATCH v9 1/3] serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr()
Date: Tue, 22 Dec 2015 10:57:21 +0200	[thread overview]
Message-ID: <20151222085720.GA3005@kuha.fi.intel.com> (raw)
In-Reply-To: <1449940707-17633-2-git-send-email-noamc@ezchip.com>

On Sat, Dec 12, 2015 at 07:18:25PM +0200, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
> 
> With the help of Heikki we take common code that
> makes sure LCR write wasn't ignored and put it in new function called
> dw8250_check_lcr(). This function serves 3 serial_out routines:
> dw8250_serial_out(), dw8250_serial_out32(), and dw8250_serial_outq().
> 
> This patch only brings better code reuse.
> 
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>

For all tree:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


Thanks,

-- 
heikki

  parent reply	other threads:[~2015-12-22  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12 17:18 [PATCH v9 0/3] serial: 8250_dw add big endian support Noam Camus
2015-12-12 17:18 ` [PATCH v9 1/3] serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr() Noam Camus
2015-12-20 16:45   ` Andy Shevchenko
2015-12-22  8:57   ` Heikki Krogerus [this message]
2015-12-12 17:18 ` [PATCH v9 2/3] serial: 8250_dw: Add support for big-endian MMIO accesses Noam Camus
2015-12-12 17:18 ` [PATCH v9 3/3] serial: 8250_dw: Do not use readl/writel before checking port iotype Noam Camus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222085720.GA3005@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noamc@ezchip.com \
    --cc=peter@hurleysoftware.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®