From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932900AbbLVMGg (ORCPT ); Tue, 22 Dec 2015 07:06:36 -0500 Received: from www.linutronix.de ([62.245.132.108]:53488 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350AbbLVMGb (ORCPT ); Tue, 22 Dec 2015 07:06:31 -0500 Date: Tue, 22 Dec 2015 13:06:28 +0100 From: Sebastian Andrzej Siewior To: Yang Shi Cc: tglx@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH v2] rt: x86: enable preemption in IST exception for x86-32 Message-ID: <20151222120628.GA27274@linutronix.de> References: <1450134404-16662-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1450134404-16662-1-git-send-email-yang.shi@linaro.org> X-Key-Id: 2A8CF5D1 X-Key-Fingerprint: 6425 4695 FFF0 AA44 66CC 19E6 7B96 E816 2A8C F5D1 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yang Shi | 2015-12-14 15:06:44 [-0800]: >Mainline kernel commit 959274753857efe9c5f1ba35fe727f51e9aa128d >("x86, traps: Track entry into and exit from IST context"), introduced >ist_enter which disables preemption uncondiontionally for both x86-64 and >x86-32. However, x86-32 does not have an IST and the stack still belongs to >the current task and there is no problem in scheduling out the task. no no. So from a quick look I *assumed* you merged your v1 and revert of the Steven's patch into one piece. But now I see that you don't disable preemption 64bit which means you revert upstream change. Here is what happens: - I drop your v2 - I merge your v1 with updated patch description - I revert "x86: Do not disable preemption in int3 on 32bit". If someone wants to skip the delayed signal on 32bit please address this upstream first (that is skip the preempt_disable() on 32bit if it is not required there). - Yang Shi, please send a changelong if you send incremental patches. Sebastian