From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932946AbbLVOty (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Dec 2015 09:49:54 -0500
Received: from mail-pf0-f177.google.com ([209.85.192.177]:34989 "EHLO
	mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753216AbbLVOtx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Dec 2015 09:49:53 -0500
Date: Tue, 22 Dec 2015 23:49:07 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 09/10] perf tools: Make 'trace' sort key default for
 tracepoint events
Message-ID: <20151222144907.GB4508@danjae.kornet>
References: <1450708013-7805-1-git-send-email-namhyung@kernel.org>
 <1450708013-7805-10-git-send-email-namhyung@kernel.org>
 <20151222072946.GD13404@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151222072946.GD13404@krava.brq.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 22, 2015 at 08:29:46AM +0100, Jiri Olsa wrote:
> On Mon, Dec 21, 2015 at 11:26:52PM +0900, Namhyung Kim wrote:
> > When an evlist contains tracepoint events only, use 'trace' sort key as
> > default.  This will make users more convenient to see trace result.
> > 
> > Suggested-by: Jiri Olsa <jolsa@redhat.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> >  tools/perf/util/sort.c | 22 +++++++++++++++++-----
> >  1 file changed, 17 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index f38a0577967a..43cb9b638718 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -2067,7 +2067,7 @@ static int sort_dimension__add(const char *tok,
> >  	return -ESRCH;
> >  }
> >  
> > -static const char *get_default_sort_order(void)
> > +static const char *get_default_sort_order(struct perf_evlist *evlist)
> >  {
> >  	const char *default_sort_orders[] = {
> >  		default_sort_order,
> > @@ -2076,13 +2076,25 @@ static const char *get_default_sort_order(void)
> >  		default_top_sort_order,
> >  		default_diff_sort_order,
> >  	};
> > +	bool use_trace = true;
> > +	struct perf_evsel *evsel;
> >  
> >  	BUG_ON(sort__mode >= ARRAY_SIZE(default_sort_orders));
> >  
> > +	evlist__for_each(evlist, evsel) {
> > +		if (evsel->attr.type != PERF_TYPE_TRACEPOINT) {
> > +			use_trace = false;
> > +			break;
> > +		}
> > +	}
> > +
> > +	if (use_trace)
> > +		return "trace";
> 
> I wonder it'd be little 'nicer' to keep the current style
> for sort orders for tracepoint even thought it has just single
> column.. like adding:
>   - default_tracepoint_sort_order = "trace"
>   - SORT_MODE__TRACEPOINT

Will change.

Thanks,
Namhyung


> 
> > +
> >  	return default_sort_orders[sort__mode];
> >  }
> 
> SNIP