From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755472AbbLVSyS (ORCPT ); Tue, 22 Dec 2015 13:54:18 -0500 Received: from down.free-electrons.com ([37.187.137.238]:36451 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752476AbbLVSyR (ORCPT ); Tue, 22 Dec 2015 13:54:17 -0500 Date: Tue, 22 Dec 2015 19:54:14 +0100 From: Alexandre Belloni To: Andrzej Hajda Cc: "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alessandro Zummo , open list Subject: Re: [PATCH] rtc: rv8803: fix handling return value of i2c_smbus_read_byte_data Message-ID: <20151222185414.GB8623@piout.net> References: <1449734133-29235-1-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449734133-29235-1-git-send-email-a.hajda@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2015 at 08:55:33 +0100, Andrzej Hajda wrote : > The function can return negative values, so its result should > be assigned to signed variable. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda > --- > drivers/rtc/rtc-rv8803.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com