From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756331AbbLWMP2 (ORCPT ); Wed, 23 Dec 2015 07:15:28 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47473 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbbLWMP0 (ORCPT ); Wed, 23 Dec 2015 07:15:26 -0500 Date: Wed, 23 Dec 2015 12:15:12 +0000 From: Mark Brown To: Jisheng Zhang Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151223121512.GV16023@sirena.org.uk> References: <20151223192338.128e95a4@xhacker> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D2rVImvqWGvKULsk" Content-Disposition: inline In-Reply-To: <20151223192338.128e95a4@xhacker> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC] spi: dw: support setting tmode dynamically X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --D2rVImvqWGvKULsk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 23, 2015 at 07:23:38PM +0800, Jisheng Zhang wrote: > Currently the spi-dw tmode is fixed to SPI_TMOD_TR if cs_control is NULL, but we > need to set it as SPI_TMOD_EPROMREAD to read nor flash, my solution is to add and > export one functions to set the tmode, then the nor flash driver call it > before reading and set back to SPI_TMOD_TR after done. What does this mean - what is TMOD and why do we need to set it to read NOR flash? I've no information on this controller... --D2rVImvqWGvKULsk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWepBPAAoJECTWi3JdVIfQThUH/3otzTUgOaWcwBNSNQqhjmg2 KckTgRYOg+JsTOIPMwpW23Oa3Hn+hyGurjL1QMuFTlkFJtoHPbXeab6KRIIiy5mT ayrUXnAVlQX2duPYrIlslS7neFGtsawEhzZ3QiAIxAoBod7lMZzalOts+NHTb+5N /JoRwgAa32Razt5QwaATLgGuN9APjs4Y4/yK14yLgryBS0SYsbuhVhOXMxOwWSFP DqG7Jy1oneGqd3SspNzqBOq+c4AndeDiyZcQPO/eiX9IBzaXZS8/cNY0rhYCRNWH E4P/ALdK5a9PDGkVe60yiq8vxaeHGI6asGG8AI4NTszGAICeYZEUM0hVvexY0S0= =rECy -----END PGP SIGNATURE----- --D2rVImvqWGvKULsk--