From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbbLWQBn (ORCPT ); Wed, 23 Dec 2015 11:01:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54447 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbbLWQBk (ORCPT ); Wed, 23 Dec 2015 11:01:40 -0500 Date: Wed, 23 Dec 2015 17:01:36 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra , "Liang, Kan" Subject: Re: [PATCH 5/8] perf script: Add stat default handlers Message-ID: <20151223160136.GA14636@krava.brq.redhat.com> References: <1450799014-31469-1-git-send-email-jolsa@kernel.org> <1450799014-31469-6-git-send-email-jolsa@kernel.org> <20151223134038.GB23199@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151223134038.GB23199@danjae.kornet> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2015 at 10:40:38PM +0900, Namhyung Kim wrote: > On Tue, Dec 22, 2015 at 04:43:31PM +0100, Jiri Olsa wrote: > > Implement struct scripting_ops::(process_stat|process_stat_interval) > > handlers - calling scripting handlers from stat events handlers. > > > > Tested-by: Kan Liang > > Link: http://lkml.kernel.org/n/tip-3iu6vmvuur1bntbnh43v3bib@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/builtin-script.c | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > > index a90bc0b81e70..656541eff151 100644 > > --- a/tools/perf/builtin-script.c > > +++ b/tools/perf/builtin-script.c > > @@ -221,6 +221,9 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel, > > struct perf_event_attr *attr = &evsel->attr; > > bool allow_user_set; > > > > + if (perf_header__has_feat(&session->header, HEADER_STAT)) > > + return 0; > > + > > allow_user_set = perf_header__has_feat(&session->header, > > HEADER_AUXTRACE); > > > > @@ -674,6 +677,18 @@ static void process_event(struct perf_script *script __maybe_unused, union perf_ > > > > static struct scripting_ops *scripting_ops; > > > > +static void process_stat(struct perf_evsel *counter, u64 time) > > +{ > > + if (scripting_ops) > > + scripting_ops->process_stat(&stat_config, counter, time); > > Shouldn't it be > > if (scripting_ops && scripting_ops->process_stat) > > ? It seems you only set it for python in patch 7.. right.. forgot about perf completely.. thanks, jirka