From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbbLXQnu (ORCPT ); Thu, 24 Dec 2015 11:43:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:44885 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbbLXQns (ORCPT ); Thu, 24 Dec 2015 11:43:48 -0500 Date: Thu, 24 Dec 2015 11:43:46 -0500 (EST) Message-Id: <20151224.114346.690529944368284120.davem@davemloft.net> To: vijay.ac.kumar@oracle.com Cc: gregkh@linuxfoundation.org, sparclinux@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, karl.volz@oracle.com Subject: Re: [PATCH] tty/serial: Skip 'NULL' char after console break when sysrq enabled From: David Miller In-Reply-To: <1450896933-192269-1-git-send-email-vijay.ac.kumar@oracle.com> References: <1450896933-192269-1-git-send-email-vijay.ac.kumar@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Dec 2015 08:43:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vijay Kumar Date: Wed, 23 Dec 2015 10:55:33 -0800 > When sysrq is triggered from console, serial driver for SUN hypervisor > console receives a console break and enables the sysrq. It expects a valid > sysrq char following with break. Meanwhile if driver receives 'NULL' > ASCII char then it disables sysrq and sysrq handler will never be invoked. > > This fix skips calling uart sysrq handler when 'NULL' is received while > sysrq is enabled. > > Signed-off-by: Vijay Kumar > Acked-by: Karl Volz Applied, thank you.