From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753686AbbLXMsQ (ORCPT ); Thu, 24 Dec 2015 07:48:16 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:16317 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752970AbbLXMsO (ORCPT ); Thu, 24 Dec 2015 07:48:14 -0500 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Thu, 24 Dec 2015 12:48:13 +0000 Date: Thu, 24 Dec 2015 12:48:12 +0000 From: James Hogan To: Guenter Roeck CC: Ralf Baechle , , , Qais Yousef Subject: Re: [PATCH -next] MIPS: VDSO: Fix build error with binutils 2.24 and earlier Message-ID: <20151224124812.GA5376@jhogan-linux.le.imgtec.org> References: <1450933471-7357-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <1450933471-7357-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.154.110] X-ESG-ENCRYPT-TAG: 30575414 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Guenter, On Wed, Dec 23, 2015 at 09:04:31PM -0800, Guenter Roeck wrote: > Commit 2a037f310bab ("MIPS: VDSO: Fix build error") tries to fix a build > error seen with binutils 2.24 and earlier. However, the fix does not work, > and again results in the already known build errors if the kernel is built > with an earlier version of binutils. >=20 > CC arch/mips/vdso/gettimeofday.o > /tmp/ccnOVbHT.s: Assembler messages: > /tmp/ccnOVbHT.s:50: Error: can't resolve `_start' {*UND* section} - `L0 {= =2Etext section} > /tmp/ccnOVbHT.s:374: Error: can't resolve `_start' {*UND* section} - `L0 = {.text section} > scripts/Makefile.build:258: recipe for target 'arch/mips/vdso/gettimeofda= y.o' failed > make[2]: *** [arch/mips/vdso/gettimeofday.o] Error 1 >=20 > Fixes: 2a037f310bab ("MIPS: VDSO: Fix build error") > Cc: Qais Yousef > Signed-off-by: Guenter Roeck > --- > Tested with binutils 2.25 and 2.22. >=20 > arch/mips/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile > index 018f8c7b94f2..14568900fc1d 100644 > --- a/arch/mips/vdso/Makefile > +++ b/arch/mips/vdso/Makefile > @@ -26,7 +26,7 @@ aflags-vdso :=3D $(ccflags-vdso) \ > # the comments on that file. > # > ifndef CONFIG_CPU_MIPSR6 > - ifeq ($(call ld-ifversion, -lt, 22500000, y),) > + ifeq ($(call ld-ifversion, -lt, 22500000, y),y) I agree this is semantically correct, but there is something more evil going on here. Originally the check was version <=3D 2.24 Qais' patch changed it to version >=3D 2.25 (intending version < 2.25) Your patch changes it to version < 2.25 I think the reason this fixed the problem for Qais is actually that he probably had a similar toolchain version to what I'm using: GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90 =2E/scripts/ld-version.sh does this: print a[1]*10000000 + a[2]*100000 + a[3]*10000 + a[4]*100 + a[5]; which changes that version number into: 20000000 + 2400000 + 900000 =3D 23300000 I.e. it doesn't expect a[3] to be >=3D 10. Should we do something like this (increase multipliers on a[1] and a[2])?: diff --git a/scripts/ld-version.sh b/scripts/ld-version.sh index 198580d245e0..0b67edc5bc6f 100755 --- a/scripts/ld-version.sh +++ b/scripts/ld-version.sh @@ -3,6 +3,6 @@ { gsub(".*)", ""); split($1,a, "."); - print a[1]*10000000 + a[2]*100000 + a[3]*10000 + a[4]*100 + a[5]; + print a[1]*100000000 + a[2]*1000000 + a[3]*10000 + a[4]*100 + a[5]; exit } which gives 2.24.90 =3D> 224900000. All call sites would need updating too to add the extra 0, but a quick git grep isn't showing any other ones than this one. Cheers James > $(warning MIPS VDSO requires binutils >=3D 2.25) > obj-vdso-y :=3D $(filter-out gettimeofday.o, $(obj-vdso-y)) > ccflags-vdso +=3D -DDISABLE_MIPS_VDSO > --=20 > 2.1.4 >=20 >=20 --azLHFNyN32YCQGCU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWe+mMAAoJEGwLaZPeOHZ6vskQAIdVoZzDWDos5y2Z4JEPFt0H Vft7LbV9ilgQEqaRuaNHcJGZY+kBNpZ2Vs89SU29Q5z5BMemjaOW0z3nnAvf4J1M jLypbiCqAT5QMMiQKzBJDmTC1EaNXkMkyerppCj1p1nepq55sTI1Z6aw2gzZr3RL wLlnSVaKLvsRGSjENks2Rjhb4BesJykC2F8UMDN1/q8Rmj8RqG2XhbMF5kscICx1 u5j4zoXfGXNDkVvYCgXbORRf1odk3eeixF/peqTPC2eBCzhi+rZ8BOTJJqO7pWXa bRo9nEQC2LAfzTHAK5nECp2eW4RNO+REY9HNJxbkOesUqJvUmhVzQu9MIUcXxjO5 6LysLViD4PuJZcKJWmsINCHM34gKAp+yf3Z+gFHVOEcoOhrWZ73R2LXvrxDoQTQW ZDeEga9FstFRBTruVLQ+An05fMrrmbGuNJLjUIak0lC/G68wIM20t/gDREStUazU iZNRdymCERz7pFeeQmIdGw5XSuawTngYej43/PsPqhAkunow/8IXeHqc+9Cf0hLB q1VJiOUXefmVC7UNXhQ22YuE9leKlYSr/vHKV8kgmcu9fJ7v3FajsyfxoQyFNY9q xR247biSPr+twIs28vPKyfUeH9d0oeqb1NudXn+uAMqGVyVtcBI3LNCwvTfXPWq2 l7/RgrS+uKvfQMmyiafY =ULhR -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--