From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932084AbbL0Wgm (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Dec 2015 17:36:42 -0500
Received: from mga09.intel.com ([134.134.136.24]:35437 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754328AbbL0Wgk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Dec 2015 17:36:40 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,487,1444719600"; 
   d="scan'208";a="849199622"
Date: Sun, 27 Dec 2015 14:36:23 -0800
From: Andi Kleen <ak@linux.intel.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-kernel@vger.kernel.org,
        Michal Marek <mmarek@suse.cz>, Guenter Roeck <linux@roeck-us.net>,
        linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix ld-version.sh to handle large 3rd version part
Message-ID: <20151227223623.GF25832@tassilo.jf.intel.com>
References: <1451170072-22846-1-git-send-email-james.hogan@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1451170072-22846-1-git-send-email-james.hogan@imgtec.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 26, 2015 at 10:47:52PM +0000, James Hogan wrote:
> The ld-version.sh script doesn't handle versions with large (>= 10) 3rd
> version components, because the 2nd component is only multiplied by 10
> times that of the 3rd component.
> 
> For example the following version string:
> GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90
> 
> gives a bogus version number:
>  20000000
> + 2400000
> +  900000 = 23300000
> 
> Breakage, confusion and mole-whacking ensues.

Thanks. Looks good. I'll fix the LTO tree.

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi