From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754782AbbL0XO0 (ORCPT ); Sun, 27 Dec 2015 18:14:26 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52414 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754052AbbL0XOW (ORCPT ); Sun, 27 Dec 2015 18:14:22 -0500 X-Sasl-enc: 5VDulLWoGWcQm26oVSyxjIoZjwz4qSJhtHeBgCYpRiFE 1451258061 Date: Sun, 27 Dec 2015 21:14:17 -0200 From: Henrique de Moraes Holschuh To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio D'Urso" Subject: Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight Message-ID: <20151227231417.GB8731@khazad-dum.debian.net> References: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450982818-11694-1-git-send-email-pali.rohar@gmail.com> X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 X-GPG-Fingerprint2: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2015, Pali Rohár wrote: > This patch adds support for controlling keyboard backlight via standard > linux led class interface (::kbd_backlight). It uses ACPI HKEY device with > MLCG and MLCS methods. > > Signed-off-by: Pali Rohár > Tested-by: Fabio D'Urso It looks good at a first glance. But at init you might need to take steps so that the current state is not changed. Did you test this? Also, is it working properly across suspend+resume? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh