From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbbL1PpK (ORCPT ); Mon, 28 Dec 2015 10:45:10 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:36190 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbbL1PpG (ORCPT ); Mon, 28 Dec 2015 10:45:06 -0500 Date: Mon, 28 Dec 2015 10:45:03 -0500 From: Tejun Heo To: Ross Zwisler Cc: Linus Torvalds , Li Zefan , Daniel Wagner , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Jones , kernel-team@fb.com, Aleksa Sarai , Michal Hocko , Ingo Molnar , Peter Zijlstra , Neil Horman Subject: Re: [PATCH] cgroup: Fix uninitialized variable warning Message-ID: <20151228154503.GP5003@mtj.duckdns.org> References: <1450907607-5060-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450907607-5060-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 23, 2015 at 02:53:27PM -0700, Ross Zwisler wrote: > Commit 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration > from subtree_control enabling") introduced the following compiler warning: > > mm/memcontrol.c: In function ‘mem_cgroup_can_attach’: > mm/memcontrol.c:4790:9: warning: ‘memcg’ may be used uninitialized in this function [-Wmaybe-uninitialized] > mc.to = memcg; > ^ > > Fix this by initializing 'memcg' to NULL. > > This was found using gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6). > > Signed-off-by: Ross Zwisler Applied to cgroup/for-4.5. Thanks. -- tejun