From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbbL2TqW (ORCPT ); Tue, 29 Dec 2015 14:46:22 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:59662 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628AbbL2TqU (ORCPT ); Tue, 29 Dec 2015 14:46:20 -0500 Date: Tue, 29 Dec 2015 14:46:15 -0500 (EST) Message-Id: <20151229.144615.1025537000748350969.davem@davemloft.net> To: wuninsu@gmail.com Cc: Dept-GELinuxNICDev@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args From: David Miller In-Reply-To: <1451417387-11321-1-git-send-email-wuninsu@gmail.com> References: <1451417387-11321-1-git-send-email-wuninsu@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Dec 2015 11:46:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Insu Yun Date: Tue, 29 Dec 2015 14:29:47 -0500 > Signed-off-by: Insu Yun > --- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c > index a5f422f..a9a2c33 100644 > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c > @@ -772,8 +772,10 @@ int qlcnic_82xx_config_intrpt(struct qlcnic_adapter *adapter, u8 op_type) > int i, err = 0; > > for (i = 0; i < ahw->num_msix; i++) { > - qlcnic_alloc_mbx_args(&cmd, adapter, > + err = qlcnic_alloc_mbx_args(&cmd, adapter, > QLCNIC_CMD_MQ_TX_CONFIG_INTR); You must fix the indentation of the second line of the function call when you made changes like this. The first character on the second line of the call must be exactly at the first column after the openning parenthesis of the first line. You must must the appropriate number of TAB and then SPACE characters necessary to achieve this. Thanks.