From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbbL2PME (ORCPT ); Tue, 29 Dec 2015 10:12:04 -0500 Received: from down.free-electrons.com ([37.187.137.238]:46177 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752868AbbL2PMC convert rfc822-to-8bit (ORCPT ); Tue, 29 Dec 2015 10:12:02 -0500 Date: Tue, 29 Dec 2015 16:11:56 +0100 From: Boris Brezillon To: Ezequiel Garcia Cc: Peter Pan , Brian Norris , David Woodhouse , Frans Klaver , Peter Pan , beanhuo@micron.com, "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , karlzhang@micron.com Subject: Re: [PATCH v2 00/12] mtd: nand_bbt: introduce independent nand BBT Message-ID: <20151229161156.77060900@bbrezillon> In-Reply-To: References: <1450159178-29895-1-git-send-email-peterpandong@micron.com> <20151229103519.31ccaf5c@bbrezillon> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Dec 2015 12:07:50 -0300 Ezequiel Garcia wrote: > On 29 December 2015 at 06:35, Boris Brezillon > wrote: > > Hi, > > > > On Mon, 28 Dec 2015 17:42:50 -0300 > > Ezequiel Garcia wrote: > > > >> This is looking a lot better, thanks for the good work! > >> > >> On 15 December 2015 at 02:59, Peter Pan wrote: > >> > Currently nand_bbt.c is tied with struct nand_chip, and it makes other > >> > NAND family chips hard to use nand_bbt.c. Maybe it's the reason why > >> > onenand has own bbt(onenand_bbt.c). > >> > > >> > Separate struct nand_chip from BBT code can make current BBT shareable. > >> > We create struct nand_bbt to take place of nand_chip in nand_bbt.c. > >> > Struct nand_bbt contains all the information BBT needed from outside and > >> > it should be embedded into NAND family chip struct (such as struct nand_chip). > >> > NAND family driver should allocate, initialize and free struct nand_bbt. > >> > > >> > Below is mtd folder structure we want: > >> > mtd > >> > ├── Kconfig > >> > ├── Makefile > >> > ├── ... > >> > ├── nand_bbt.c > >> > >> Hm.. I'm not sure about having nand_bbt.c in drivers/mtd. > >> What's wrong with drivers/mtd/nand ? > > > > I haven't reviewed the series yet, but I agree. If the BBT code is only > > meant to be used on NAND based devices, it should probably stay in > > drivers/mtd/nand. > > > >> > >> In fact, I was thinking we could go further and clean up the directories a bit > >> by separating core code, from controllers code, from SPI NAND code: > >> > >> drivers/mtd/nand/ > >> drivers/mtd/nand/controllers > >> drivers/mtd/nand/spi > >> > >> Makes any sense? > > > > Actually I had the secret plan of moving all (raw) NAND controller > > drivers into the drivers/mtd/nand/controllers directory, though this > > was for a different reason: I'd like to create another directory for > > manufacturer specific code in order to support some advanced features > > on NANDs that do not implement (or only partially implement) the ONFI > > standard. > > > > The separation you're talking about here is more related to the > > interface used to communicate with the NAND chip. > > > > How about using the following hierarchy? > > > > drivers/mtd/nand/ > > drivers/mtd/nand/interfaces/raw/ > > drivers/mtd/nand/interfaces/raw/controllers/ > > drivers/mtd/nand/interfaces/spi/ > > drivers/mtd/nand/interfaces/onenand/ > > drivers/mtd/nand/chips/ > > > > What do you think? > > > > I believe we are bikeshedding here, but what the heck. > > That seems too involved. A simpler hierarchy could be clear enough, > and seems to follow what other subsystems do: > > drivers/mtd/nand/ > drivers/mtd/nand/raw/ And probably some common logic in there too. > drivers/mtd/nand/spi/ > drivers/mtd/nand/onenand/ > drivers/mtd/nand/chips/ > I'm fine with this one too ;-). -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com