From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751719AbcAABI1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Dec 2015 20:08:27 -0500
Received: from h2.hallyn.com ([78.46.35.8]:48272 "EHLO h2.hallyn.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751179AbcAABIZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Dec 2015 20:08:25 -0500
Date: Thu, 31 Dec 2015 19:08:23 -0600
From: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Richard Guy Briggs <rgb@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Serge E. Hallyn" <serge@hallyn.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC] is_global_init() called on global init sub-thread
Message-ID: <20160101010823.GB26243@mail.hallyn.com>
References: <20151230062542.GA605@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151230062542.GA605@swordfish>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 30, 2015 at 03:25:42PM +0900, Sergey Senozhatsky wrote:
> Hello,
> 
> re-upping https://www.redhat.com/archives/linux-audit/2013-December/msg00086.html
> 
> Oleg Nesterov wrote:
> 
> :Because is_global_init() is only true for the main thread of /sbin/init.
> :
> :Just look at oom_unkillable_task(). It tries to not kill init. But, say,
> :select_bad_process() can happily find a sub-thread of is_global_init()
> :and still kill it.
> 
> this is still the case, isn't it? at least in some -stable kernels.
> is there (or was there) any reason this change has never been committed?
> (I'm particularly interested in is_global_init()).

...  seems like it makes sense.  Can you remind us which init you're having
to deal with?

>  static inline int is_global_init(struct task_struct *tsk)
>  {
> -	return tsk->pid == 1;
> +	return task_tgid_nr(tsk) == 1;
>  }
> 
> 	-ss