From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751505AbcABLum (ORCPT ); Sat, 2 Jan 2016 06:50:42 -0500 Received: from mga04.intel.com ([192.55.52.120]:56255 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbcABLuj (ORCPT ); Sat, 2 Jan 2016 06:50:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,512,1444719600"; d="scan'208";a="852184000" Date: Sat, 2 Jan 2016 19:49:51 +0800 From: kbuild test robot To: Markus Pargmann Cc: kbuild-all@01.org, Jens Axboe , linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net, kernel@pengutronix.de, Markus Pargmann Subject: [PATCH] nbd: fix ifnullfree.cocci warnings Message-ID: <20160102114951.GA37337@lkp-hsx03.intel.com> References: <201601021924.2eNo09uj%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451729825-11481-2-git-send-email-mpa@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/block/nbd.c:937:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/block/nbd.c:918:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Markus Pargmann Signed-off-by: Fengguang Wu --- nbd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -914,8 +914,7 @@ static int nbd_dev_dbg_init(struct nbd_d static void nbd_dev_dbg_close(struct nbd_device *nbd) { - if (nbd->dbg_dir) - debugfs_remove_recursive(nbd->dbg_dir); + debugfs_remove_recursive(nbd->dbg_dir); } static int nbd_dbg_init(void) @@ -933,8 +932,7 @@ static int nbd_dbg_init(void) static void nbd_dbg_close(void) { - if (nbd_dbg_dir) - debugfs_remove_recursive(nbd_dbg_dir); + debugfs_remove_recursive(nbd_dbg_dir); } #else /* IS_ENABLED(CONFIG_DEBUG_FS) */