From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbcACL4h (ORCPT ); Sun, 3 Jan 2016 06:56:37 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:51746 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcACL4c (ORCPT ); Sun, 3 Jan 2016 06:56:32 -0500 Date: Sun, 3 Jan 2016 03:56:31 -0800 From: Christoph Hellwig To: Markus Pargmann Cc: Jens Axboe , linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net, kernel@pengutronix.de, Oleg Nesterov , Christoph Hellwig Subject: Re: [PATCH 2/5] nbd: Remove signal usage Message-ID: <20160103115630.GA9803@infradead.org> References: <1451729825-11481-1-git-send-email-mpa@pengutronix.de> <1451729825-11481-3-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451729825-11481-3-git-send-email-mpa@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Markus, this looks great! Reviewed-by: Christoph Hellwig One thing I noticed, which might be a good cleanup in the future: > - spin_lock_irqsave(&nbd->tasks_lock, flags); > nbd->task_recv = current; > - spin_unlock_irqrestore(&nbd->tasks_lock, flags); It seems like task_{send,recv} are only used for the files showing the pids. Maybe you should just store the pids directly in the nbd_device structure and also keep the sysfs file around for the life time of that structure.