From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbcADWQJ (ORCPT ); Mon, 4 Jan 2016 17:16:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48903 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbcADWQG (ORCPT ); Mon, 4 Jan 2016 17:16:06 -0500 Date: Mon, 04 Jan 2016 17:16:04 -0500 (EST) Message-Id: <20160104.171604.1609827563372626339.davem@davemloft.net> To: wuninsu@gmail.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH] mISDN: correctly handling failed allocation From: David Miller In-Reply-To: <1451425126-26958-1-git-send-email-wuninsu@gmail.com> References: <1451425126-26958-1-git-send-email-wuninsu@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Jan 2016 14:16:05 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Insu Yun Date: Tue, 29 Dec 2015 16:38:46 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference might be happened. > > Signed-off-by: Insu Yun Sorry, this is not a correct fix. You need to propagate an error back to the callers, and they must act upon that error.