From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbcAECrl (ORCPT ); Mon, 4 Jan 2016 21:47:41 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:50704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbcAECri (ORCPT ); Mon, 4 Jan 2016 21:47:38 -0500 Date: Mon, 04 Jan 2016 21:47:33 -0500 (EST) Message-Id: <20160104.214733.921867451376206917.davem@davemloft.net> To: fw@strlen.de Cc: dvyukov@google.com, herbert@gondor.apana.org.au, tgraf@suug.ch, daniel@iogearbox.net, chamaken@gmail.com, nicolas.dichtel@6wind.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, kcc@google.com, glider@google.com, sasha.levin@oracle.com, edumazet@google.com, zbr@ioremap.net Subject: Re: [PATCH] connector: bump skb->users before callback invocation From: David Miller In-Reply-To: <20151231132633.GA30790@breakpoint.cc> References: <20151231132633.GA30790@breakpoint.cc> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Jan 2016 18:47:38 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Westphal Date: Thu, 31 Dec 2015 14:26:33 +0100 > Dmitry reports memleak with syskaller program. > Problem is that connector bumps skb usecount but might not invoke callback. > > So move skb_get to where we invoke the callback. > > Reported-by: Dmitry Vyukov > Signed-off-by: Florian Westphal Applied and queued up for -stable, thanks.