From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbcADPmu (ORCPT ); Mon, 4 Jan 2016 10:42:50 -0500 Received: from smtprelay0015.hostedemail.com ([216.40.44.15]:34991 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751374AbcADPmt (ORCPT ); Mon, 4 Jan 2016 10:42:49 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2894:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3872:4321:4362:5007:6261:7576:7875:7903:9040:10004:10400:10848:10967:11232:11658:11914:12295:12296:12517:12519:12555:12663:12740:13069:13311:13357:14659:21080:30054:30064:30070:30079:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: glove13_1856bb1707f12 X-Filterd-Recvd-Size: 2253 Date: Mon, 4 Jan 2016 10:42:46 -0500 From: Steven Rostedt To: Colin King Cc: Li Bin , Russell King , Will Deacon , linux-kernel@vger.kernel.org, Fengguang Wu Subject: Re: [PATCH] scripts: recordmcount: fix incorrect use of sprintf Message-ID: <20160104104246.636bc47a@gandalf.local.home> In-Reply-To: <1451516801-16951-1-git-send-email-colin.king@canonical.com> References: <1451516801-16951-1-git-send-email-colin.king@canonical.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Dec 2015 23:06:41 +0000 Colin King wrote: > From: Colin Ian King > > Fix build warning: > > scripts/recordmcount.c:589:4: warning: format not a string > literal and no format arguments [-Wformat-security] > sprintf("%s: failed\n", file); > > Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object file") > Signed-off-by: Colin Ian King > --- > scripts/recordmcount.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c > index 301d70b..e1675927 100644 > --- a/scripts/recordmcount.c > +++ b/scripts/recordmcount.c > @@ -586,7 +586,7 @@ main(int argc, char *argv[]) > do_file(file); > break; > case SJ_FAIL: /* error in do_file or below */ > - sprintf("%s: failed\n", file); > + fprintf(stderr, "%s: failed\n", file); Paper bag bug. I'm not sure how this passed my tests? My tests check for warnings. And I even got a "BUILD SUCCESS" from Fengguang Wu's kbuild test robot. I'll apply it, test it, and push it out soon. Thanks! -- Steve > ++n_error; > break; > case SJ_SUCCEED: /* premature success */