From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251AbcADOUU (ORCPT ); Mon, 4 Jan 2016 09:20:20 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:40488 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbcADOUR (ORCPT ); Mon, 4 Jan 2016 09:20:17 -0500 Date: Mon, 4 Jan 2016 15:20:01 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Andre Przywara Cc: Maxime Ripard , Chen-Yu Tsai , arnd@arndb.de, Herbert Xu , marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , linux-crypto@vger.kernel.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Message-ID: <20160104142001.GB28361@pengutronix.de> References: <1450787267-26836-1-git-send-email-andre.przywara@arm.com> <1450787267-26836-3-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450787267-26836-3-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 22, 2015 at 12:27:44PM +0000, Andre Przywara wrote: > The min3() macro expects all arguments to be of the same type (or > size at least). While two arguments are ints or u32s, one is size_t, > which does not match on 64-bit architectures. > Cast the size_t to u32 to make min3() happy. In this context here the > length should never exceed 32 bits anyway. > > Signed-off-by: Andre Przywara > --- > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 12 ++++++------ > drivers/crypto/sunxi-ss/sun4i-ss-hash.c | 8 ++++---- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > index a19ee12..b3bc7bd 100644 > --- a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > +++ b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c > @@ -79,7 +79,7 @@ static int sun4i_ss_opti_poll(struct ablkcipher_request *areq) > oi = 0; > oo = 0; > do { > - todo = min3(rx_cnt, ileft, (mi.length - oi) / 4); > + todo = min3(rx_cnt, ileft, (u32)(mi.length - oi) / 4); For this case the min function has a min_t variant to specify the argument. What about introducing min3_t? BTW, I don't understand why min3(x, y, z) isn't just defined as #define min3(x, y, z) min(min(x, y), z) but instead as: #define min3(x, y, z) min((typeof(x))min(x, y), z) . I thought min(x, y) has the same type as x anyhow? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |