From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbcADPSr (ORCPT ); Mon, 4 Jan 2016 10:18:47 -0500 Received: from foss.arm.com ([217.140.101.70]:53377 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcADPSp (ORCPT ); Mon, 4 Jan 2016 10:18:45 -0500 Date: Mon, 4 Jan 2016 15:18:41 +0000 From: Catalin Marinas To: Zhi-zhou Zhang Cc: jistone@redhat.com, daniel.thompson@linaro.org, marc.zyngier@arm.com, mark.rutland@arm.com, will.deacon@arm.com, salyzyn@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: entry.S: add missing trace_hardirqs_off Message-ID: <20160104151840.GF6301@e104818-lin.cambridge.arm.com> References: <1451109438-5834-1-git-send-email-zhizhou.zh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451109438-5834-1-git-send-email-zhizhou.zh@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 26, 2015 at 01:57:18PM +0800, Zhi-zhou Zhang wrote: > Before calling schedule, we should trace hardirqs correctly. If not, > we get following warning message when enabled CONFIG_DEBUG_LOCKDEP: > > [ 9.243073] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) > [ ... ] > [ 9.262681] possible reason: unannotated irqs-off. > [ 9.263018] irq event stamp: 256209 > [ 9.263266] hardirqs last enabled at (256209): [] el0_irq_naked+0x1c/0x24 > [ 9.263820] hardirqs last disabled at (256207): [] __do_softirq+0x170/0x28c > [ 9.264419] softirqs last enabled at (256208): [] __do_softirq+0x1ec/0x28c > [ 9.264976] softirqs last disabled at (256189): [] irq_exit+0x9c/0xec > > Signed-off-by: Zhi-zhou Zhang > --- > arch/arm64/kernel/entry.S | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index 7ed3d75..4769190 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -634,6 +634,9 @@ work_pending: > bl do_notify_resume > b ret_to_user > work_resched: > +#ifdef CONFIG_TRACE_IRQFLAGS > + bl trace_hardirqs_off > +#endif > bl schedule A similar patch is already in -next as commit db3899a6477a (arm64: Add trace_hardirqs_off annotation in ret_to_user) -- Catalin