From: Jerry Snitselaar <jsnitsel@redhat.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, peterhuewe@gmx.de,
tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com
Subject: Re: [tpmdd-devel] [PATCH] tpm: remove unneeded include of actbl2.h
Date: Mon, 4 Jan 2016 13:11:26 -0700 [thread overview]
Message-ID: <20160104201126.GA6098@cantor.redhat.com> (raw)
In-Reply-To: <1451935183-2514-1-git-send-email-jsnitsel@redhat.com>
On Mon Jan 04 16, Jerry Snitselaar wrote:
>tpm_tis.c already gets actbl2.h via linux/acpi.h -> acpi/acpi.h ->
>acpi/actbl.h -> acpi/actbl2.h, so the direct include in tpm_tis.c
>is not needed.
>
>Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
>---
>
>Jarrko, this is a trivial thing I noticed while doing some work.
>Not sure if you guys care, but thought I'd send it in anyways.
>
> drivers/char/tpm/tpm_tis.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>index 65f7eec..461d486 100644
>--- a/drivers/char/tpm/tpm_tis.c
>+++ b/drivers/char/tpm/tpm_tis.c
>@@ -28,7 +28,6 @@
> #include <linux/wait.h>
> #include <linux/acpi.h>
> #include <linux/freezer.h>
>-#include <acpi/actbl2.h>
> #include "tpm.h"
>
> enum tis_access {
>--
>2.6.1
>
Not sure what happened, but it doesn't look like it CC'd Jarkko even
though it shows it in the git send-email output. Adding the other
maintainers as well.
0001-tpm-remove-unneeded-include-of-actbl2.h.patch
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
jarkko.sakkinen@linux.intel.com
Subject: [PATCH] tpm: remove unneeded include of actbl2.h
Date: Mon, 4 Jan 2016 12:19:43 -0700
Message-Id: <1451935183-2514-1-git-send-email-jsnitsel@redhat.com>
X-Mailer: git-send-email 2.6.1
Send this email? ([y]es|[n]o|[q]uit|[a]ll): a
OK. Log says:
Server: smtp.corp.redhat.com
MAIL FROM:<jsnitsel@redhat.com>
RCPT TO:<tpmdd-devel@lists.sourceforge.net>
RCPT TO:<linux-kernel@vger.kernel.org>
RCPT TO:<jarkko.sakkinen@linux.intel.com>
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
jarkko.sakkinen@linux.intel.com
Subject: [PATCH] tpm: remove unneeded include of actbl2.h
Date: Mon, 4 Jan 2016 12:19:43 -0700
Message-Id: <1451935183-2514-1-git-send-email-jsnitsel@redhat.com>
X-Mailer: git-send-email 2.6.1
Result: 250 2.0.0 u04JJkA6027832 Message accepted for delivery
next prev parent reply other threads:[~2016-01-04 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 19:19 Jerry Snitselaar
2016-01-04 20:11 ` Jerry Snitselaar [this message]
2016-01-05 6:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104201126.GA6098@cantor.redhat.com \
--to=jsnitsel@redhat.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome