From: Borislav Petkov <bp@alien8.de>
To: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: tthayer@opensource.altera.com, dinh.linux@gmail.com,
dougthompson@xmission.com, mchehab@osg.samsung.com,
linux@arm.linux.org.uk, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support
Date: Mon, 4 Jan 2016 21:30:46 +0100 [thread overview]
Message-ID: <20160104203045.GO22941@pd.tnic> (raw)
In-Reply-To: <568AD038.7070200@opensource.altera.com>
On Mon, Jan 04, 2016 at 02:04:08PM -0600, Dinh Nguyen wrote:
> altr_edac.c originally added support for SDRAM. Now we're adding support
> for L2 and OCRAM into the same file by using #ifdef
> CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to
> move the l2 and ocram implementation into separate files.
So what's wrong with adding those to the same file and using different
registration functions? Like xgene_edac does, for example.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-01-04 20:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:38 dinguyen
2015-11-19 18:34 ` Borislav Petkov
2016-01-04 17:17 ` Dinh Nguyen
2016-01-04 19:46 ` Borislav Petkov
2016-01-04 20:04 ` Dinh Nguyen
2016-01-04 20:30 ` Borislav Petkov [this message]
2016-01-04 20:46 ` Dinh Nguyen
2016-01-04 20:59 ` Borislav Petkov
2016-01-04 20:55 ` Dinh Nguyen
2016-01-04 21:07 ` Borislav Petkov
2016-01-04 21:33 ` Thor Thayer
2016-01-04 22:01 ` Borislav Petkov
2016-01-04 23:42 ` Thor Thayer
2016-01-05 10:58 ` Borislav Petkov
2016-01-05 20:37 ` Thor Thayer
2016-01-05 21:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104203045.GO22941@pd.tnic \
--to=bp@alien8.de \
--cc=dinguyen@opensource.altera.com \
--cc=dinh.linux@gmail.com \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@osg.samsung.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome