From: Johannes Weiner <hannes@cmpxchg.org>
To: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, adityakali@google.com,
tj@kernel.org, linux-api@vger.kernel.org,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
lxc-devel@lists.linuxcontainers.org, akpm@linux-foundation.org,
ebiederm@xmission.com, gregkh@linuxfoundation.org,
lizefan@huawei.com, Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH 3/8] cgroup: introduce cgroup namespaces
Date: Mon, 4 Jan 2016 16:47:27 -0500 [thread overview]
Message-ID: <20160104214727.GA10618@cmpxchg.org> (raw)
In-Reply-To: <20160104202053.GA23238@mail.hallyn.com>
On Mon, Jan 04, 2016 at 02:20:53PM -0600, Serge E. Hallyn wrote:
> On Mon, Jan 04, 2016 at 01:54:48PM -0600, serge.hallyn@ubuntu.com wrote:
> > @@ -2166,6 +2178,43 @@ static struct file_system_type cgroup2_fs_type = {
> > .kill_sb = cgroup_kill_sb,
> > };
> >
> > +char *
>
> Sorry, that one should be 'static char *'
Lol, that took a while to find. Please don't quote over 500 lines to
comment on a trivial issue of one line.
next prev parent reply other threads:[~2016-01-04 21:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 19:54 CGroup Namespaces (v9) serge.hallyn
2016-01-04 19:54 ` [PATCH 1/8] kernfs: Add API to generate relative kernfs path serge.hallyn
2016-01-04 19:54 ` [PATCH 2/8] sched: new clone flag CLONE_NEWCGROUP for cgroup namespace serge.hallyn
2016-01-04 19:54 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn
2016-01-04 20:20 ` Serge E. Hallyn
2016-01-04 21:47 ` Johannes Weiner [this message]
2016-01-05 2:07 ` [PATCH 3/8 v2] " Serge E. Hallyn
2016-01-06 2:17 ` [PATCH 3/8 v3] " Serge E. Hallyn
2016-01-04 19:54 ` [PATCH 4/8] cgroup: cgroup namespace setns support serge.hallyn
2016-01-04 19:54 ` [PATCH 5/8] kernfs: define kernfs_node_dentry serge.hallyn
2016-01-04 19:54 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn
2016-01-04 19:54 ` [PATCH 7/8] cgroup: Add documentation for cgroup namespaces serge.hallyn
2016-01-04 19:54 ` [PATCH 8/8] Add FS_USERNS_FLAG to cgroup fs serge.hallyn
2016-01-05 0:53 ` CGroup Namespaces (v9) Serge E. Hallyn
2016-01-05 19:36 ` Serge E. Hallyn
-- strict thread matches above, loose matches on Subject: below --
2016-01-29 8:54 CGroup Namespaces (v10) serge.hallyn
2016-01-29 8:54 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn
2015-12-23 4:23 CGroup Namespaces (v8) serge.hallyn
2015-12-23 4:23 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn
2015-12-23 16:15 ` Tejun Heo
2015-12-09 19:28 CGroup Namespaces (v7) serge.hallyn
2015-12-09 19:28 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104214727.GA10618@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=adityakali@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=lxc-devel@lists.linuxcontainers.org \
--cc=serge.hallyn@canonical.com \
--cc=serge.hallyn@ubuntu.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome