From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbcAEKHT (ORCPT ); Tue, 5 Jan 2016 05:07:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41871 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbcAEKHL (ORCPT ); Tue, 5 Jan 2016 05:07:11 -0500 Date: Tue, 5 Jan 2016 11:07:08 +0100 From: Jiri Olsa To: Wang Nan Cc: will.deacon@arm.com, jolsa@kernel.org, takahiro.akashi@linaro.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, pi3orama@163.com, Arnaldo Carvalho de Melo Subject: Re: [RFC PATCH v2] perf test: Improve bp_signal Message-ID: <20160105100708.GA29394@krava.brq.redhat.com> References: <20160104165535.GI1616@arm.com> <1451987875-15893-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451987875-15893-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 09:57:55AM +0000, Wang Nan wrote: > Will Deacon [1] has some question on patch [2]. This patch improves > test__bp_signal so we can test: > > 1. A watchpoint and a breakpoint that fire on the same instruction > 2. Nested signals > > Test result: > > On x86_64 and ARM64 (result are similar with patch [2] on ARM64): > > # ./perf test -v signal > 17: Test breakpoint overflow signal handler : > --- start --- > test child forked, pid 10213 > count1 1, count2 3, count3 2, overflow 3, overflows_2 3 > test child finished with 0 > ---- end ---- > Test breakpoint overflow signal handler: Ok > > So at least 2 cases Will doubted are handled correctly. > > [1] http://lkml.kernel.org/g/20160104165535.GI1616@arm.com > [2] http://lkml.kernel.org/g/1450921362-198371-1-git-send-email-wangnan0@huawei.com > > Signed-off-by: Wang Nan > Signed-off-by: Jiri Olsa > Cc: Will Deacon > Cc: Arnaldo Carvalho de Melo > --- > > v1 -> v2: Improve readability, fix typo. Thanks to Jiri Olsa. > > To Jiri: I guess you will be okay to provide your SOB for your code at [3], > so I add it in this v2 patch. sure, patch looks good to me thanks, jirka