From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: dsterba@suse.cz, Qu Wenruo <quwenruo.btrfs@gmx.com>,
Sanidhya Solanki <jpage.lkml@gmail.com>,
calestyo@scientia.net, clm@fb.com, jbacik@fb.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BTRFS: Adds an option to select RAID Stripe size
Date: Tue, 5 Jan 2016 11:16:01 +0100 [thread overview]
Message-ID: <20160105101601.GQ4227@twin.jikos.cz> (raw)
In-Reply-To: <56847AEC.8080409@cn.fujitsu.com>
On Thu, Dec 31, 2015 at 08:46:36AM +0800, Qu Wenruo wrote:
> > Let me note that a good reputation is also built from patch reviews
> > (hint hint).
>
> I must admit I'm a bad reviewer.
> As when I review something, I always has an eager to rewrite part or all
> the patch to follow my idea, even it's just a choice between different
> design.
Yeah that's natural, but even if one does not completely agree, it's
still possible to verify that the implementation is correct.
The reviews also help to find and share some common style of
implementation so the maintainers don't scream when they see a patch and
developers and are not suprised that the patches take several rounds.
prev parent reply other threads:[~2016-01-05 10:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 12:24 Sanidhya Solanki
2015-12-29 13:39 ` David Sterba
2015-12-29 11:15 ` Sanidhya Solanki
2015-12-29 17:06 ` David Sterba
2015-12-29 21:32 ` Sanidhya Solanki
2015-12-30 6:39 ` Sanidhya Solanki
2015-12-30 11:59 ` Qu Wenruo
2015-12-30 9:54 ` Sanidhya Solanki
2015-12-30 14:10 ` Qu Wenruo
2015-12-30 11:15 ` Sanidhya Solanki
2015-12-30 15:58 ` David Sterba
2015-12-30 21:19 ` Sanidhya Solanki
2015-12-30 16:17 ` David Sterba
2015-12-30 21:21 ` Sanidhya Solanki
2016-01-05 10:33 ` David Sterba
2015-12-31 0:46 ` Qu Wenruo
2016-01-05 10:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105101601.GQ4227@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=calestyo@scientia.net \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=jpage.lkml@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®