From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751922AbcAEKi0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 05:38:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48470 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751477AbcAEKiY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 05:38:24 -0500
Date: Tue, 5 Jan 2016 11:38:20 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint
 events
Message-ID: <20160105103820.GA5133@krava.brq.redhat.com>
References: <1450708013-7805-1-git-send-email-namhyung@kernel.org>
 <1450708013-7805-6-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450708013-7805-6-git-send-email-namhyung@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 21, 2015 at 11:26:48PM +0900, Namhyung Kim wrote:

SNIP

> +	free(str);
> +	return ret;
> +}
> +
>  static int __sort_dimension__add(struct sort_dimension *sd)
>  {
>  	if (sd->taken)
> @@ -1667,6 +1887,9 @@ static int sort_dimension__add(const char *tok,

sort_dimension__add's evlist arg could loose the '__maybe_unused' now

thanks,
jirka

>  		return 0;
>  	}
>  
> +	if (!add_dynamic_entry(evlist, tok))
> +		return 0;
> +
>  	return -ESRCH;
>  }
>  
> -- 
> 2.6.4
>